search

nodejs / gyp-next

A fork of the GYP build system for use in the Node.js projects
BSD 3-Clause "New" or "Revised" License
125 stars 69 forks source link

fix: declare packaging in package discovery #247

Closed legendecas closed 2 months ago

legendecas commented 2 months ago

packaging needs to be declared in setuptools package discovery config.

cclauss commented 2 months ago

We should revert #214 if we are going this way.

We will need to teach JavaScript folks how to run pip.

https://docs.python.org/3/whatsnew/3.10.html#distutils-deprecated

legendecas commented 2 months ago

yeah, this seems to publish packaging globally. I dont think this is the correct way.

legendecas commented 2 months ago

@cclauss Would you mind creating a revert on #214? I think packaging should be declared as a required dependency, it can be installed on python < 3.12 as well.

cclauss commented 2 months ago

The preferred solution is setuptools; python_version >= "3.12"

legendecas commented 2 months ago

That would change the python version requirement of node: https://github.com/nodejs/node/blob/main/BUILDING.md#note-about-python