chore: fix XCConfigurationList assertion

nodejs / gyp-next

A fork of the GYP build system for use in the Node.js projects

BSD 3-Clause "New" or "Revised" License

130 stars 73 forks source link

chore: fix XCConfigurationList assertion #264

Closed legendecas closed 1 month ago

legendecas commented 3 months ago

Fix tests.

Weirdly, GitHub action didn't run for https://github.com/nodejs/gyp-next/pull/263 and it showed green to be merged. I enabled the following settings for the repo to avoid accidental merge if GitHub action was not triggered.

Require status checks to pass before merging, and
Require branches to be up to date before merging (the original PR needs to be updated with the main branch before merging so that we don't have to fixup again).

cclauss commented 3 months ago

Either line 7 or line 9 (I never remember which) of .github/workflows/python_tests.yml should be removed so that GHA's run for PRs from project maintainers.

legendecas commented 3 months ago

Either line 7 or line 9 (I never remember which) of .github/workflows/python_tests.yml should be removed so that GHA's run for PRs from project maintainers.

Updated!

Now for outdated PRs, GitHub UI shows as:

legendecas commented 1 month ago

@cclauss would you mind taking a look at this so that the CI on PRs like https://github.com/nodejs/gyp-next/pull/266 can be fixed? Thanks!

legendecas commented 1 month ago

I usually push to my own fork repo so I'd bet it won't be triggered for my branches in duplication.