search

nodejs / http-parser

http request/response parser for c
MIT License
6.33k stars 1.53k forks source link

support overriding HTTP_MAX_HEADER_SIZE at runtime #453

Closed cjihrig closed 5 years ago

cjihrig commented 5 years ago

This commit adds http_parser_set_max_header_size(), which can override the compile time HTTP_MAX_HEADER_SIZE value.

cjihrig commented 5 years ago

Is https://ci.nodejs.org/view/All/job/http-parser-test/ the correct CI job? I tried to run it (https://ci.nodejs.org/view/All/job/http-parser-test/26/) with no luck.

mcollina commented 5 years ago

It would be good to have a unit test for this here.

bnoordhuis commented 5 years ago

A regression test would be nice but HTTP_MAX_HEADER_SIZE didn't have one either.

@cjihrig There's no CI job for http-parser.