search

nodejs / i18n

The Node.js Internationalization Working Group – A Community Committee initiative.
MIT License
150 stars 39 forks source link

Rename primary branch to main. #502

Closed mhdawson closed 2 years ago

mhdawson commented 3 years ago

We are going through all of the node.js repositories to rename the primary branch to main. Please see nodejs/node#33864 for more context.

I also don't see any references to master in githbub workflows so I don't think there should be issues with the rename.

Please let me know if there are any concerns otherwise I'll look to do the rename Friday May 4th.

TiagoDanin commented 3 years ago

Required branch change in Crowdin.

CC @obensource @zeke

zeke commented 3 years ago

It appears that this repository is still being synced with Crowdin using Crowdin's OAuth-based GitHub integration.

That integration is owned (and can only be updated) by the @nodejs-crowdin GitHub user.

Screen Shot 2021-06-01 at 9 41 20 PM

We could potential solve two "problems" at once here by switching from the Oauth integration to the newer, preferred, GitHub-Actions powered integration: https://github.com/crowdin/github-action -- that would make the sync process codified in the repo for all to see, rather than tucked away in a GitHub integration that very few people know about or have access to.

That said, a new Actions-based integration would still need to be set up with the @nodejs-crowdin GitHub user, which exists for this specific purpose (syncing files between GitHub and Crowdin).

Are @obensource and I the only folks in the working group who have access to that bot account's credentials?

mhdawson commented 3 years ago

@obensource want to sync to see how to move this forward.

Andrulko commented 3 years ago

@obensource @mhdawson If you decide to rename the branch from master to main in this repository, please rename master in Crowdin project first of all, otherwise the existing master will be removed from Crowdin after renaming

mhdawson commented 2 years ago

@obensource can you do the rename for crowdin? We are done to a small set of repos that need the rename to be completed and this is one of them.

mhdawson commented 2 years ago

@srl295 do you know who is still active and might do the crowdin part?

mhdawson commented 2 years ago

@zeke. @rvagg can you add my key to https://github.com/nodejs-private/secrets/tree/master/i18n so I could try to log in and do the requested rename in crowdin before renaming the primary branch.

mhdawson commented 2 years ago

or even better @zeke if you could help do the rename when I rename the primary branch that would be even better.

mhdawson commented 2 years ago

We discussed in the TSC meeting and I got agreement we should rename as I've not been able to get any help/response in terms of fixing up crowdin first. If there is somebody that can help to fix that up after the rename let me know.

mhdawson commented 2 years ago

Renamed

JohnTitor commented 2 years ago

@alexandrtovmach 👋 Could you take a look at the settings on Crowdin if you have some time?

Andrulko commented 2 years ago

The master was renamed to main in advance in the project: https://crowdin.com/project/nodejs/zh-CN

The only remaining item - you need to re-connect the integration via Integrations -> GitHub or adjust GHA script if it's used.

Note that it's totally safe to delete the integration and set it up again: https://crowdin.com/project/nodejs/apps/system/github

The only requirement - it should be configured by GitHub user with admin access to the repo