search

nodejs / i18n

The Node.js Internationalization Working Group – A Community Committee initiative.
MIT License
150 stars 40 forks source link

Remove unneeded files #758

Closed JohnTitor closed 1 year ago

JohnTitor commented 1 year ago

We no longer have to sync content here, and removed related packages.

AugustinMauroy commented 1 year ago

I think it's a good idea.

nschonni commented 1 year ago

@AugustinMauroy why did you block the PR and then remove all the prevously translated content? Removing the translated content wasn't what this PR was proposing. Please don't push unrelated changes into someone elses PR

AugustinMauroy commented 1 year ago

why did you block the PR

Because we remove a piece of code that can be used in the reflection

nschonni commented 1 year ago

They are no translated content on this repo.

Incorrect, this repo has been used to translate the API docs with Crowdin long before the website onboarded

AugustinMauroy commented 1 year ago

And translation stay on Crowdin. Just remove from here. Also if we remove the script for uploading and downloading. This content will become out of date.

nschonni commented 1 year ago

@AugustinMauroy I get that you're eager to help, but this isn't correct. Generally in OSS it's bad etique to push changes to other peoples branches without discussing. If you think removing the content is the right thing, you can open your own PR and describe why you thing this is right, rather than highjacking someone else's PR. This PR was opened to stop additional sync PRs for the active branches only. You're suggesting wiping out the translation history

JohnTitor commented 1 year ago

@nodejs/i18n Could anyone tweak the "Require status checks to pass before merging" config on the branch protection rule?

TiagoDanin commented 1 year ago

@nodejs/i18n Could anyone tweak the "Require status checks to pass before merging" config on the branch protection rule?

I will close and reopen the pull request. Hope this fixes it

JohnTitor commented 1 year ago

I will close and reopen the pull request. Hope this fixes it

No, it won't. The repo config needs to be tweaked as mentioned.