Closed timfish closed 6 months ago
should we also update the README to make the named export the recommended usage?
@timfish should there best test additions too? I.e. if something's exported, it should be tested that that interface works?
should there best test additions too? I.e. if something's exported, it should be tested that that interface works?
I modified both an ESM and CJS test to use this new export!
I modified both an ESM and CJS test to use this new export!
Oops! I should have noticed that. 😅
And I see that other test files retain the usage of the default export. SGTM/LGTM.
import-in-the-middle
has some ESM interop issues.From here:
This causes issues with some bundlers. Obviously bundled imports will not go through
import-in-the-middle
but using it should not inhibit bundlers as iitm can still hook build-in modules.This PR adds a
Hook
named export and changes one cjs and esm test to use that new export.