Slack inviter doesn't work - Githubissues

nodejs / inclusivity

Improving inclusivity in the node community

80 stars 22 forks source link

Slack inviter doesn't work #123

Closed williamkapke closed 8 years ago

williamkapke commented 8 years ago

I tried it out and it appears to have some bugs.

I am not @59 ...

screenshot 2016-04-18 09 37 37

It didn't work, I'm guessing it has a blank email address...??

screenshot 2016-04-18 09 37 01

scottgonzalez commented 8 years ago

Hmm...I'm seeing this too. Very odd since the user info is tied to cookies.

ghost commented 8 years ago

i can finally reveal that i have cookies that transcend time and space

(no but seriously this is weird)

scottgonzalez commented 8 years ago

Seems like request.sessionID is no longer a thing that exists in newer versions of Express...

scottgonzalez commented 8 years ago

This is unfortunate because it means that there need to be changes down in https://github.com/scottgonzalez/connect-oauth-github. I don't have time to work on this right now though. I can probably work on it tonight.

nebrius commented 8 years ago

Funny story, I had to deal with session stuff in express recently myself, and yeah it was spun off into https://github.com/expressjs/session.

scottgonzalez commented 8 years ago

Funny story, I had to deal with session stuff in express recently myself, and yeah it was spun off into https://github.com/expressjs/session.

I'm not sure why both express-session and cookie-session exist in the express org, but switching to express-session fixed the problem without having to make any changes to connect-oauth-github :-)

scottgonzalez commented 8 years ago

This should be fixed from https://github.com/nodejs/inclusivity-slack-inviter/issues/2. Can you verify?

williamkapke commented 8 years ago

Still some oddness... It is showing your name & email still. I cleared my cookies and did a refresh, but it didn't change. I clicked the button anyhow and it says I'm already a member :/

Is this just me? Maybe... ::shrugs::

scottgonzalez commented 8 years ago

Ok. After my fix was merged, I tried to use the inviter and it showed my info, so I assumed it had been deployed again. I guess it was just restarted and not deployed. When I'm at a computer, I'll connect to the server and get it updated.

scottgonzalez commented 8 years ago

I just logged into the server and it was in fact still on the old code. I've updated it and restarted the process. I also went through the invitation process to ensure that when you test again you'll see the bug if it still exists.

williamkapke commented 8 years ago

🎉 Works now :D