search

nodejs / iojs.org

https://iojs.org
Other
232 stars 130 forks source link

iojs-el:Add new translations for template.json #408

Closed AntouanK closed 9 years ago

fhemberger commented 9 years ago

@nodejs/iojs-el, please review.

fhemberger commented 9 years ago

Can you please remove the old index.md file if the new template works for you? Thanks!

AntouanK commented 9 years ago

@sirodoht Added a new commit for that. Thanks.

AntouanK commented 9 years ago

@fhemberger If I remove the index.md file, do I have to add anything else? Or does the template.json cover all the translations?

fhemberger commented 9 years ago

template.json replaces the index.md entirely. You can see this if you remove the file and build the website locally.

AntouanK commented 9 years ago

@fhemberger I removed index.md and added another missing translation ( was in index.md ) Only thing missing is the "Critical update" message which I think is not in the JSON file.

fhemberger commented 9 years ago

No, the update message comes from a different source. For critical security updates, we don't have the time to go through the translation process, so this message is English for all language variants.

AntouanK commented 9 years ago

@fhemberger Are we ok with that PR? Do we need something more?

fhemberger commented 9 years ago

@AntouanK Just waiting for a +1 from @nodejs/iojs-el …

AvraamMavridis commented 9 years ago

:+1:

fhemberger commented 9 years ago

Aaaand there it is, merging!

AntouanK commented 9 years ago

@AvraamMavridis Thanks