Open yorkie opened 5 years ago
I think the first step is to figure out how to copy the tests in Node.js to this repo on a regular basis.
ie. keep the test suite bundled into the core Node.js repo, but figure out how to create a separate copy from that suite on a regular basis.
Once we have that working we should have a better understanding with respect to the linkage between the Node.js runtime and the challenges of having the tests be separate.
I think the first step is to figure out how to copy the tests in Node.js to this repo on a regular basis.
We have an alternative script to do that: https://github.com/Rokid/ShadowNode/blob/master/tools/pull-napi.sh, which downloads the official tar and unzip to a local dest by the following:
$ sh ./pull-napi.sh v10.10.0
I'm glad to implement this on napi-test-suite if the above proposal LGTY :)
@yorkie maybe the first step is to use your script locally and then push the first version of the files to the
napi-test-suite/src
directory
and add directions to the README.md on how to use that source to build/test on Node.js and on shadowNode ?
Then next step would then be to add your script to napi-test-suite/tools along with instructions on how to use it to generate an update for the napi-test-suite/src directory.
Does the script also run on linux? I see some checks for OSX, but not sure if you are already running it on linux as well?
Does the script also run on linux? I see some checks for OSX, but not sure if you are already running it on linux as well?
Maybe we could write this script in Node.js that we could get cross-platform :)
maybe the first step is to use your script locally and then push the first version of the files to the napi-test-suite/src directory
I will make a PR :p
@mhdawson I have created a PR with N-API tests and headers at #3, please take a review for me, thanks :)
Hi @nodejs/n-api, before drafting the first version of the N-API test suite, I think we have the following issues to address.
Questions collection
My proposal
For example, a bugfix on current implementation on Node.js itself is submitted on our main repository nodejs/node, the test suite needs to be merged on
nodejs/napi-test-suite
as a precondition, this seems a little verbose to contributors.A suggestion is to keep the latest test suite for N-API still on Node.js, and archives tests when releasing a Node.js version. Archives tests means:
v0.10.0
) on the master branch.@nodejs/napi-test-suite
?When the above proposal is accepted and complete, the others only needs to use
npm install
by a specific version, and run these tests by themselves. And there is no necessary to use this in Node.js, too, this is for Node.js-like runtimes only.When the above proposal is accepted and complete, we could skip this problem as well.
/cc @gabrielschulhof @mhdawson