search

nodejs / js-native-api-test

Node.js js-native-api-test suite, externalized so that it can be used to test Node-API implementations outside of Node.js
MIT License
7 stars 10 forks source link

Discussion on node-addon-api test suite #6

Open legendecas opened 5 years ago

legendecas commented 5 years ago

node-addon-api composites multiple C interface N-API to a C++ API and it is maintained officially by Node.js working groups, if test suite covers node-addon-api shall be maintained a copy in napi-test-suite?

mhdawson commented 5 years ago

@lengendecas. I'm not sure that is needed. node-addon-api only depends on the C N-API functions exported by Node.js (or another N-API implementation).

So, for other N-API implementations they should be able to just build/run the node-addon-test suite as is. If tweaks/changes are needed to allow them to run the tests then that is probably best handled through changes in the node-addon-api repo.

One of the key differences is that we don't expect different implementations of node-addon-api, it should be able to be used by all implementations that support all of the exported N-API functions.

legendecas commented 5 years ago

The issue we've encountered is that node-addon-api used some es6 features(symbols, here) in a crucial code path that not supported in ShadowNode yet, which depends on aJS engine still on a very early ECMA stage.

So the naïve idea is n-api test suite could generates a report if node-addon-api are supported on the N-API implementations, or some parts of node-addon-api are supported.