Add languages support - Githubissues

nodejs / live.nodejs.org

Website for Node.js Live.

34 stars 35 forks source link

Add languages support #43

Closed xcatliu closed 8 years ago

xcatliu commented 8 years ago

Hi @hackygolucky ,

I finished the localization of Node Live Beijing, then added some features. Now it's easy to add another language to this site. Please help to review the change of build script when you have time.

@JacksonTian @XadillaX Please help to review the translation.

Solved https://github.com/nodejs/Intl/issues/31

hackygolucky commented 8 years ago

ohmigosh. This is so rad!

Thanks @xcatliu Verified as good on my end, but if you'd like to wait to have another person check the translation 🎉

xcatliu commented 8 years ago

@nodejs/nodejs-cn Can somebody help me check the translation? Thanks!

haoxins commented 8 years ago

I can review within this week!

laosb commented 8 years ago

All good :+1:! LGTM

xcatliu commented 8 years ago

Hi, @coderhaoxin Have you finished reviewing?

haoxins commented 8 years ago

LGTM

xcatliu commented 8 years ago

@laosb @coderhaoxin Thanks for your reviewing! @hackygolucky It's ready to be merged now :)

laosb commented 8 years ago

Glad to see!