Unused llparse_blobs in llhttp.c causing compilation errors

nodejs / llhttp

Port of http_parser to llparse

http://llhttp.org

Other

1.68k stars 184 forks source link

Unused llparse_blobs in llhttp.c causing compilation errors #43

Closed codebytere closed 4 years ago

codebytere commented 4 years ago

When this repo is built, the generated llhttp.c file contains unused llparse_blobs; at present llparse_blob1[], llparse_blob7[], llparse_blob9[], and llparse_blob10[] are unused.

This causes compilation failures in Electron.js, since we do not allow unused variables. I'm happy to open a PR to address this myself if i can be pointed in the right direction!

cc @indutny

fanatid commented 4 years ago

It was fixed few hours ago in llparse: https://github.com/nodejs/llparse/pull/34 llparse@6.2.1 was released, now everything should be fine :)

codebytere commented 4 years ago

@fanatid thanks! appreciated 🙇‍♀