src: fix performance regression

nodejs / llnode

An lldb plugin for Node.js and V8, which enables inspection of JavaScript states for insights into Node.js processes and their core dumps.

Other

1.15k stars 100 forks source link

Closed mmarchini closed 5 years ago

mmarchini commented 6 years ago

Performance overhead was huge when we had a huge amount of contexts. Two improvements were necessary to reduce the overhead:

Keep a cache of context maps (just like we do for object maps)
Use std::unordered_set instead of std::set to store contexts
- Also use it on TypeRecord::instances_, since it is faster
- Don't use find before insert, sets don't have duplicates by definition

mmarchini commented 5 years ago

cc @cjihrig @joyeecheung @Drieger

mmarchini commented 5 years ago

Landed in 388605f