nodejs / llnode

An lldb plugin for Node.js and V8, which enables inspection of JavaScript states for insights into Node.js processes and their core dumps.
Other
1.15k stars 99 forks source link

build: drop v6.x support #292

Closed mmarchini closed 4 years ago

mmarchini commented 4 years ago

Node.js v6.x is EOL. Keeping it around makes it more dificult to support new versions, so dropping support seems reasonable. This is semver-major.

codecov-io commented 4 years ago

Codecov Report

Merging #292 into master will decrease coverage by 1.93%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #292      +/-   ##
==========================================
- Coverage   81.79%   79.85%   -1.94%     
==========================================
  Files          33       33              
  Lines        4229     4229              
==========================================
- Hits         3459     3377      -82     
- Misses        770      852      +82
Impacted Files Coverage Δ
src/error.h 85.71% <0%> (-14.29%) :arrow_down:
test/plugin/workqueue-test.js 88.88% <0%> (-11.12%) :arrow_down:
src/printer.cc 79.51% <0%> (-6.2%) :arrow_down:
src/llv8-constants.cc 83.49% <0%> (-5.83%) :arrow_down:
src/node-constants.cc 88.88% <0%> (-3.18%) :arrow_down:
src/llv8-inl.h 92.67% <0%> (-2.93%) :arrow_down:
src/node.cc 87.8% <0%> (-2.44%) :arrow_down:
src/llnode.cc 74.2% <0%> (-0.8%) :arrow_down:
src/llv8.cc 75.46% <0%> (-0.62%) :arrow_down:
test/common.js 87% <0%> (-0.57%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 13f7034...a5ecbe1. Read the comment docs.

mmarchini commented 4 years ago

cc @nodejs/llnode @nodejs/diagnostics @nodejs/post-mortem for visibility

mmarchini commented 4 years ago

Landed in e1a74b0