mmarchini commented 4 years ago

Previous code was too strict when hitting a context which it was unable to read Locals information: it would stop looping through the contexts even if we still had valid contexts in the queue. Changing it to loop through all context and all Locals in a context should give us a more reliable results.

Also, if a given object was found in a context Locals but we're unable to read the Local name, we'll show it as ??? to indicate it's being referenced but we couldn't read its name (in case of corrupted memory, for example).

Fixes: https://github.com/nodejs/llnode/issues/278

codecov-io commented 4 years ago

Codecov Report

Merging #295 into master will decrease coverage by <.01%. The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master     #295      +/-   ##
==========================================
- Coverage   79.23%   79.22%   -0.01%     
==========================================
  Files          33       33              
  Lines        4229     4232       +3     
==========================================
+ Hits         3351     3353       +2     
- Misses        878      879       +1

Impacted Files	Coverage Δ
src/llscan.cc	`61.33% <83.33%> (+0.02%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e1a74b0...76e5f2b. Read the comment docs.

mmarchini commented 4 years ago

Landed in 0dbfad0

nodejs / llnode

src: fix findrefs for context locals #295

Codecov Report