search

nodejs / llnode

An lldb plugin for Node.js and V8, which enables inspection of JavaScript states for insights into Node.js processes and their core dumps.
Other
1.15k stars 99 forks source link

src: use new SystemPointerSize constant #300

Closed mmarchini closed 4 years ago

mmarchini commented 4 years ago

This alone should fix a lot of issues. It was enough to get a reasonable stack trace from a Node.js v12.3.0 core dump, ran with --interpreted-frames-native-stack. For some reason v8 bt is not working when running Node.js in lldb.

codecov-io commented 4 years ago

Codecov Report

Merging #300 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #300   +/-   ##
======================================
  Coverage    78.6%   78.6%           
======================================
  Files          33      33           
  Lines        4225    4225           
======================================
  Hits         3321    3321           
  Misses        904     904
Impacted Files Coverage Δ
src/llv8-constants.cc 82.52% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fb25c91...bcb291e. Read the comment docs.

mmarchini commented 4 years ago

Landed in 2c4c99c