mmarchini commented 5 years ago

Adding list to the README so that ncu can parse approvals correctly (without pointing to a local copy of nodejs/node README). List extracted from the @nodejs/llnode GitHub team.

codecov-io commented 5 years ago

Codecov Report

Merging #305 into master will decrease coverage by 0.61%. The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #305      +/-   ##
=========================================
- Coverage   79.21%   78.6%   -0.62%     
=========================================
  Files          33      33              
  Lines        4225    4225              
=========================================
- Hits         3347    3321      -26     
- Misses        878     904      +26

Impacted Files	Coverage Δ
src/llv8.cc	`71.11% <0%> (-2.49%)`	:arrow_down:
src/llv8.h	`80.95% <0%> (-2.39%)`	:arrow_down:
src/llv8-constants.h	`98.48% <0%> (-1.52%)`	:arrow_down:
src/llv8-inl.h	`92.58% <0%> (-1.06%)`	:arrow_down:
src/llv8-constants.cc	`82.52% <0%> (-0.98%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2c4c99c...aec422c. Read the comment docs.

mmarchini commented 4 years ago

Meh, not worth it, especially if we adopt #370

nodejs / llnode

doc: add collaborators list to README #305

Codecov Report