nodejs / llnode

An lldb plugin for Node.js and V8, which enables inspection of JavaScript states for insights into Node.js processes and their core dumps.
Other
1.15k stars 99 forks source link

Bump minimum LLDB version to 8 on next major #307

Closed mmarchini closed 4 years ago

mmarchini commented 4 years ago

The unwinding algorithm used by lldb had a bug up to lldb 7 which would prevent proper unwinding of frames on Node.js 12 (#306). The issue is fixed on lldb 8 though. Since there isn't much we can do on our side to fix the issue, I suggest we increase the minimum suggested lldb version to 8. We might even want to throw a warning to users using an older version.

We might need to suggest Linux users to install from the LLVM official PPA (which might be a good idea anyway, the lldb shipped with Ubuntu has several readline issues which prevent command history and autocomplete).

I'm not sure how this would work on OS X. I don't have access to an OS X machine now to try it now, but based on our CI I assume OS X is using lldb 9 now.

mmarchini commented 4 years ago

Didn't really see any needs for this lately, so let's forget it for now.