search

nodejs / llnode

An lldb plugin for Node.js and V8, which enables inspection of JavaScript states for insights into Node.js processes and their core dumps.
Other
1.15k stars 100 forks source link

src: use Check() instead of raw != -1 #313

Closed mmarchini closed 4 years ago

mmarchini commented 5 years ago

a501635516aa0c153b1e17b62e47150b6458af99 changed the behavior of Check() so that it could be properly used to determine if an object was loaded successfully from memory. In the past we used raw != -1 to perform the same check. Some places were still using the old approach, which has less guarantees than Check(). This commit changes those places to use the new approach. Also added a few RETURN_IF_THIS_INVALID guards on the functions touched by this commit.

mmarchini commented 4 years ago

cc @nodejs/llnode

mmarchini commented 4 years ago

Landed in 37b3c2684432