search

nodejs / llnode

An lldb plugin for Node.js and V8, which enables inspection of JavaScript states for insights into Node.js processes and their core dumps.
Other
1.15k stars 100 forks source link

Upcoming metadata changes on V8 7.8 #317

Closed mmarchini closed 4 years ago

mmarchini commented 5 years ago 
The following metadata has changed:

- v8dbg_class_JSDate__value__Object
  - The postmortem metadata generation script needed to be
    updated. No action should be required by postmortem tools.

- v8dbg_class_JSRegExp__source__Object
  - The postmortem metadata generation script needed to be
    updated. No action should be required by postmortem tools.
mmarchini commented 5 years ago

cc @cjihrig did you have a chance to send these changes upstream?

cjihrig commented 5 years ago

Not yet. I need to upstream this commit specifically: https://github.com/nodejs/node/commit/8d05991d1089563d0073628951fbf44afada0d68

cjihrig commented 5 years ago

Update: Upstream changes in https://chromium-review.googlesource.com/c/v8/v8/+/1849139.

mmarchini commented 4 years ago

We're supporting v12, so I guess this was done :woman_shrugging: