search

nodejs / llnode

An lldb plugin for Node.js and V8, which enables inspection of JavaScript states for insights into Node.js processes and their core dumps.
Other
1.15k stars 99 forks source link

Node.js v12 + master support #318

Closed mmarchini closed 4 years ago

mmarchini commented 4 years ago

Just opening the PR to share the working version of v12.x (and master) fixes. I still have to clean up several of those commits (and rewrite their commit messages) and the idea is to open them as separate PRs. IIRC they do not depend on each other (but several depend on #303, which is why I haven't opened their PRs yet).

It's also worth noting that v12 won't work without https://chromium-review.googlesource.com/c/v8/v8/+/1847783 and https://chromium-review.googlesource.com/c/v8/v8/+/1832311.

codecov-io commented 4 years ago

Codecov Report

Merging #318 into master will decrease coverage by 0.12%. The diff coverage is 81.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #318      +/-   ##
==========================================
- Coverage   79.02%   78.89%   -0.13%     
==========================================
  Files          33       33              
  Lines        4247     4388     +141     
==========================================
+ Hits         3356     3462     +106     
- Misses        891      926      +35
Impacted Files Coverage Δ
src/llv8-constants.cc 84.45% <100%> (+1.38%) :arrow_up:
src/llv8-constants.h 100% <100%> (ø) :arrow_up:
src/llscan.cc 61.25% <100%> (ø) :arrow_up:
test/common.js 86.55% <100%> (-0.45%) :arrow_down:
src/constants.h 87.5% <100%> (+20.83%) :arrow_up:
src/llv8.h 83.72% <100%> (+0.38%) :arrow_up:
src/error.h 87.5% <100%> (+1.78%) :arrow_up:
src/llv8.cc 73.29% <64.1%> (+0.31%) :arrow_up:
src/printer.cc 75.89% <64.58%> (-1.81%) :arrow_down:
src/constants.cc 80.59% <77.77%> (-0.76%) :arrow_down:
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ec01604...581dde8. Read the comment docs.