Closed mmarchini closed 4 years ago
Merging #323 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #323 +/- ##
=======================================
Coverage 79.02% 79.02%
=======================================
Files 33 33
Lines 4247 4247
=======================================
Hits 3356 3356
Misses 891 891
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update ec01604...45b83f7. Read the comment docs.
Over in CITGM we're proposing keeping Travis around for code coverage: https://github.com/nodejs/citgm/pull/759
Over in CITGM we're proposing keeping Travis around for code coverage: nodejs/citgm#759
Let me take a look, I don't think we had to enable any permissions for codecov in this repository (I remember making a PR and codecov was just working).
Over in CITGM we're proposing keeping Travis around for code coverage: nodejs/citgm#759
Let me take a look, I don't think we had to enable any permissions for codecov in this repository (I remember making a PR and codecov was just working).
I think that was the point @targos was making -- that on Travis nothing extra had to be enabled for codecov but that wasn't the case for Actions.
fyi I'm testing on my fork to avoid notification spam here.
I'm having trouble getting tests to pass because apparently core dumps are not being generated. Not sure why yet, based on system settings it doesn't look like core dumps are blocked.
Should be working now. A few things we still need to do:
Ok, I'm happy with this setup now. CI is a lot faster than Travis, and it's able to run more jobs in parallel as well.
We lost the build matrix for now, but I don't think it's a problem. If someone creates a https://github.com/bjfish/travis-matrix-badges for GitHub Actions, we can use it. I also wouldn't be surprised if GitHub makes this information easily accessible in the repository home page in the future.
I had to change coverage from Codecov to Coveralls because Codecov doesn't use the GITHUB_TOKEN
yet. Coveralls doesn't add a comment in the repository, but coverage information is available as a GitHub Check:
cc @nodejs/llnode @richardlau
Landed in 9a58d8cf3fa1...ecb8d0e34236
Reduce CI time by moving to GitHub Actions.