nodejs / llnode

An lldb plugin for Node.js and V8, which enables inspection of JavaScript states for insights into Node.js processes and their core dumps.

Other

1.15k stars 99 forks source link

build: move CI to GitHub Actions #323

Closed mmarchini closed 4 years ago

mmarchini commented 4 years ago

Reduce CI time by moving to GitHub Actions.

codecov-io commented 4 years ago

Codecov Report

Merging #323 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #323   +/-   ##
=======================================
  Coverage   79.02%   79.02%           
=======================================
  Files          33       33           
  Lines        4247     4247           
=======================================
  Hits         3356     3356           
  Misses        891      891

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ec01604...45b83f7. Read the comment docs.

richardlau commented 4 years ago

Over in CITGM we're proposing keeping Travis around for code coverage: https://github.com/nodejs/citgm/pull/759

mmarchini commented 4 years ago

Over in CITGM we're proposing keeping Travis around for code coverage: nodejs/citgm#759

Let me take a look, I don't think we had to enable any permissions for codecov in this repository (I remember making a PR and codecov was just working).

richardlau commented 4 years ago

Over in CITGM we're proposing keeping Travis around for code coverage: nodejs/citgm#759

Let me take a look, I don't think we had to enable any permissions for codecov in this repository (I remember making a PR and codecov was just working).

I think that was the point @targos was making -- that on Travis nothing extra had to be enabled for codecov but that wasn't the case for Actions.

richardlau commented 4 years ago

For reference: https://community.codecov.io/t/whitelist-github-action-servers-to-upload-without-a-token/491

mmarchini commented 4 years ago

fyi I'm testing on my fork to avoid notification spam here.

I'm having trouble getting tests to pass because apparently core dumps are not being generated. Not sure why yet, based on system settings it doesn't look like core dumps are blocked.

mmarchini commented 4 years ago

Should be working now. A few things we still need to do:

[x] Daily runs
[x] Update README
[x] Code coverage. codecov said they will enable GITHUB_TOKEN support after Nov 13 (https://community.codecov.io/t/whitelist-github-action-servers-to-upload-without-a-token/491/8). Still won't work for forks though. TBH I don't feel strong enough about keeping codecov around if we need two CI services for that (llnode needs to run all tests on all supported Node.js versions to generate a relevant coverage report, keeping travis would kill the purpose of speeding up CI).
[ ] Better handling of nightly/canary tests (I have ideas, will probably open an issue about that later)

mmarchini commented 4 years ago

Ok, I'm happy with this setup now. CI is a lot faster than Travis, and it's able to run more jobs in parallel as well.

We lost the build matrix for now, but I don't think it's a problem. If someone creates a https://github.com/bjfish/travis-matrix-badges for GitHub Actions, we can use it. I also wouldn't be surprised if GitHub makes this information easily accessible in the repository home page in the future.

I had to change coverage from Codecov to Coveralls because Codecov doesn't use the GITHUB_TOKEN yet. Coveralls doesn't add a comment in the repository, but coverage information is available as a GitHub Check:

img-2020-01-09-103941

cc @nodejs/llnode @richardlau

mmarchini commented 4 years ago

Landed in 9a58d8cf3fa1...ecb8d0e34236