nodejs / llnode

An lldb plugin for Node.js and V8, which enables inspection of JavaScript states for insights into Node.js processes and their core dumps.
Other
1.15k stars 99 forks source link

src: v12.x-compatible DescriptorArray #325

Closed mmarchini closed 4 years ago

mmarchini commented 4 years ago

V8 changed DescriptorArray from a FixedArray to a proper HeapObject. These changes update accessors for DescriptorArray fields to make them compatible with FixedArray-like and HeapObject-like access.

Ref: https://github.com/nodejs/llnode/issues/255

codecov-io commented 4 years ago

Codecov Report

Merging #325 into master will increase coverage by 0.32%. The diff coverage is 56.97%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #325      +/-   ##
==========================================
+ Coverage   78.32%   78.64%   +0.32%     
==========================================
  Files          33       33              
  Lines        4262     4290      +28     
==========================================
+ Hits         3338     3374      +36     
+ Misses        924      916       -8
Impacted Files Coverage Δ
src/llv8.h 83.33% <ø> (+2.38%) :arrow_up:
src/llv8-constants.h 100% <ø> (+1.51%) :arrow_up:
src/llv8-constants.cc 83.06% <100%> (+1.01%) :arrow_up:
src/llscan.cc 61.25% <100%> (ø) :arrow_up:
src/printer.cc 76.38% <39.28%> (-1.32%) :arrow_down:
src/llv8.cc 72.43% <50%> (+1.81%) :arrow_up:
src/llv8-inl.h 91.76% <71.42%> (-0.11%) :arrow_down:
src/llnode_module.cc 89.87% <0%> (-0.64%) :arrow_down:
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9a58d8c...bc5641f. Read the comment docs.

mmarchini commented 4 years ago

cc @nodejs/llnode

mmarchini commented 4 years ago

Ping @nodejs/llnode, we need this for v12 support.

mmarchini commented 4 years ago

Superseded by #330