search

nodejs / llnode

An lldb plugin for Node.js and V8, which enables inspection of JavaScript states for insights into Node.js processes and their core dumps.
Other
1.15k stars 99 forks source link

test: make func source test compatbile with v12 #326

Closed mmarchini closed 4 years ago

mmarchini commented 4 years ago

The string stored in V8 with the function source code is different on v12. Update the regexp used in our test to match older and newer versions.

codecov-io commented 4 years ago

Codecov Report

Merging #326 into master will decrease coverage by 0.02%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #326      +/-   ##
==========================================
- Coverage   78.32%   78.29%   -0.03%     
==========================================
  Files          33       33              
  Lines        4262     4262              
==========================================
- Hits         3338     3337       -1     
- Misses        924      925       +1
Impacted Files Coverage Δ
src/llnode_module.cc 89.87% <0%> (-0.64%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9a58d8c...a5ae3f5. Read the comment docs.

mmarchini commented 4 years ago

cc @nodejs/llnode

mmarchini commented 4 years ago

Ping @nodejs/llnode, we need this for v12 support.

mmarchini commented 4 years ago

Landed in fd9d2b099093