mmarchini
commented
4 years ago cc cc @nodejs/llnode @nodejs/diagnostics
Closed mmarchini closed 4 years ago
mmarchini
commented
4 years ago cc cc @nodejs/llnode @nodejs/diagnostics
mmarchini
commented
4 years ago Landed in 878b514e2919...e8896e0d3932
coveralls
commented
7 months ago We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report. To ensure accuracy in future PRs, please see these guidelines. A quick fix for this PR: rebase it; your next report should be accurate.
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| src/llv8-constants.h | 1 | 2 | 50.0% | ||
| test/plugin/frame-test.js | 3 | 8 | 37.5% | ||
| src/llv8-constants.cc | 48 | 60 | 80.0% | ||
| src/llv8.cc | 17 | 30 | 56.67% | ||
| src/printer.cc | 37 | 56 | 66.07% | ||
| src/llv8-inl.h | 78 | 122 | 63.93% | ||
| <!-- | Total: | 192 | 286 | 67.13% | --> |
| Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| src/llv8-constants.h | 1 | 95.59% | ||
| src/printer.cc | 1 | 76.9% | ||
| src/llv8.h | 2 | 78.57% | ||
| src/llv8-constants.cc | 5 | 81.96% | ||
| src/llv8-inl.h | 98 | 69.44% | ||
| <!-- | Total: | 107 | --> |
| Totals | |
|---|---|
| Change from base Build 878b514e2919e1adf7974694bf36cdd7286cdec8: | 3.6% |
| Covered Lines: | 3707 |
| Relevant Lines: | 4703 |
This PR contains all commits necessary to make llnode work on v12, plus changes to CI to run tests on v12, drop v8 and v11, and bump the major version since we're dropping support and adding new one. I made a PR on nodejs/node to update the list of postmortem constants used, but I noticed some of the constants here already changes on v13, so we'll have to work on that.