nodejs / llnode

An lldb plugin for Node.js and V8, which enables inspection of JavaScript states for insights into Node.js processes and their core dumps.
Other
1.15k stars 99 forks source link

src: update SFI script accessor for V8 8.1 #352

Closed mmarchini closed 4 years ago

mmarchini commented 4 years ago

The metadata used to access the script field from an SFI changed on V8 8.1. The field is still the same, so no other changes are necessary. This fixes v8 bt on 8.1, as well as stack-test suite.

mmarchini commented 4 years ago

Landed in 8e2a55c82e99

coveralls commented 6 months ago

Pull Request Test Coverage Report for Build ba90ab9ca91d5bbb0a3b1689ae30186deb6973a1-PR-352

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report. To ensure accuracy in future PRs, please see these guidelines. A quick fix for this PR: rebase it; your next report should be accurate.


Changes Missing Coverage Covered Lines Changed/Added Lines %
src/llv8-inl.h 2 3 66.67%
<!-- Total: 4 5 80.0% -->
Files with Coverage Reduction New Missed Lines %
src/llv8-inl.h 1 69.65%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 1948512b5e71913455f47ff9eb26372762d9b1d0: 4.5%
Covered Lines: 3715
Relevant Lines: 4711

💛 - Coveralls