search

nodejs / llnode

An lldb plugin for Node.js and V8, which enables inspection of JavaScript states for insights into Node.js processes and their core dumps.
Other
1.15k stars 99 forks source link

Double-check unused Double Field code #353

Closed mmarchini closed 4 years ago

mmarchini commented 4 years ago

The if branch on https://github.com/nodejs/llnode/blob/master/src/llv8.cc#L1178-L1202 is essentially a noop: double value is set but never used, since we'll always return Value(). Not sure if we should be returning double value or if we can remove this code.