Closed mmarchini closed 4 years ago
mmarchini
commented
4 years ago I don't think it should be a semver major since we dropped support before, but I understand if other folks feel otherwise.
Also, the text is not entirely accurate, since v13 is not supported (and probably never will be).
mmarchini
commented
4 years ago Landed in fdddce0d2c7d
coveralls
commented
6 months ago We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report. To ensure accuracy in future PRs, please see these guidelines. A quick fix for this PR: rebase it; your next report should be accurate.
| Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| src/constants.cc | 1 | 80.3% | ||
| src/error.h | 1 | 87.5% | ||
| src/llv8-constants.cc | 2 | 85.2% | ||
| src/llv8.cc | 3 | 71.04% | ||
| src/llnode_api.cc | 8 | 87.5% | ||
| test/common.js | 9 | 79.24% | ||
| src/node-inl.h | 11 | 0.0% | ||
| src/node.h | 12 | 20.0% | ||
| test/plugin/workqueue-test.js | 13 | 55.17% | ||
| src/node.cc | 21 | 37.5% | ||
| <!-- | Total: | 217 | --> |
| Totals | |
|---|---|
| Change from base Build 7b9598e9dad0a00e1b7ddd1aabd9cf7dddb3cab4: | 3.8% |
| Covered Lines: | 3715 |
| Relevant Lines: | 4711 |
Signed-off-by: Matheus Marchini mmarchini@netflix.com