search

nodejs / llnode

An lldb plugin for Node.js and V8, which enables inspection of JavaScript states for insights into Node.js processes and their core dumps.
Other
1.15k stars 99 forks source link

chore(ci): temporarily disable OS X #368

Closed mmarchini closed 4 years ago

mmarchini commented 4 years ago

Refs: https://github.com/nodejs/llnode/issues/362

mmarchini commented 4 years ago

cc @nodejs/llnode

joyeecheung commented 4 years ago

It seems that --abort-on-uncaught-exception has regressed on Node.js v14 which is why the test is timing out (instead of aborting, the process exits with -1 normally)

mmarchini commented 4 years ago

It seems that --abort-on-uncaught-exception has regressed on Node.js v14 which is why the test is timing out (instead of aborting, the process exits with -1 normally)

Ah yes, that might cause v14 tests to fail, although I'm pretty sure llnode is broken on v14 since we bumped V8 recently (as in, after the last time we updated things on llnode).

codecov-commenter commented 4 years ago

Codecov Report

Merging #368 into master will increase coverage by 0.05%. The diff coverage is 81.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #368      +/-   ##
==========================================
+ Coverage   78.93%   78.98%   +0.05%     
==========================================
  Files          33       33              
  Lines        4262     4744     +482     
==========================================
+ Hits         3364     3747     +383     
- Misses        898      997      +99
Impacted Files Coverage Δ
src/constants.h 88.88% <ø> (+11.11%) :arrow_up:
src/error.cc 82.60% <0.00%> (-1.61%) :arrow_down:
src/error.h 100.00% <ø> (+12.50%) :arrow_up:
src/llv8.cc 71.71% <56.75%> (-1.35%) :arrow_down:
src/printer.cc 81.15% <68.33%> (+3.45%) :arrow_up:
src/llv8-inl.h 90.42% <84.37%> (-2.50%) :arrow_down:
test/plugin/frame-test.js 83.33% <84.61%> (-4.17%) :arrow_down:
src/llv8-constants.cc 85.92% <91.66%> (+2.91%) :arrow_up:
src/constants.cc 82.08% <100.00%> (+7.84%) :arrow_up:
src/llscan.cc 59.41% <100.00%> (-1.85%) :arrow_down:
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fe9a668...e2906bd. Read the comment docs.

joyeecheung commented 4 years ago

From https://github.com/nodejs/node/issues/32981 it seems the bug was introduced from v12.11.0. Is there any progress in the V8 upstream?

mmarchini commented 4 years ago

I don't think I opened an upstream bug :thinking: I'll check tomorrow and will open one if I haven't yet.

mmarchini commented 4 years ago

Although tests are passing on v12, so that issue should be unrelated (hopefully)