nodejs / llnode

An lldb plugin for Node.js and V8, which enables inspection of JavaScript states for insights into Node.js processes and their core dumps.
Other
1.15k stars 99 forks source link

chore(ci): use codecov instead of coveralls #371

Closed mmarchini closed 4 years ago

mmarchini commented 4 years ago

coveralls is failing, and codecov seems to be working on actions now, so replace coveralls with codecov.

codecov-commenter commented 4 years ago

Codecov Report

Merging #371 into master will increase coverage by 0.05%. The diff coverage is 81.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #371      +/-   ##
==========================================
+ Coverage   78.93%   78.98%   +0.05%     
==========================================
  Files          33       33              
  Lines        4262     4744     +482     
==========================================
+ Hits         3364     3747     +383     
- Misses        898      997      +99     
Impacted Files Coverage Δ
src/constants.h 88.88% <ø> (+11.11%) :arrow_up:
src/error.cc 82.60% <0.00%> (-1.61%) :arrow_down:
src/error.h 100.00% <ø> (+12.50%) :arrow_up:
src/llv8.cc 71.71% <56.75%> (-1.35%) :arrow_down:
src/printer.cc 81.15% <68.33%> (+3.45%) :arrow_up:
src/llv8-inl.h 90.42% <84.37%> (-2.50%) :arrow_down:
test/plugin/frame-test.js 83.33% <84.61%> (-4.17%) :arrow_down:
src/llv8-constants.cc 85.92% <91.66%> (+2.91%) :arrow_up:
src/constants.cc 82.08% <100.00%> (+7.84%) :arrow_up:
src/llscan.cc 59.41% <100.00%> (-1.85%) :arrow_down:
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fe9a668...f9b77f0. Read the comment docs.

mmarchini commented 4 years ago

@nodejs/llnode @nodejs/diagnostics this unbreaks linux CI on pull requests (OS X has a different problem due to Catalina and we should disable OS XCI for now until someone can investigate how to fix it)