search

nodejs / llnode

An lldb plugin for Node.js and V8, which enables inspection of JavaScript states for insights into Node.js processes and their core dumps.
Other
1.15k stars 99 forks source link

PSA: added branch protection rules for `master` & disabled merge option #372

Closed mmarchini closed 3 years ago

mmarchini commented 3 years ago

Added branch restriction rules for master to require CI against up to date default branch as well as enforce linear history. Folks with admin access can still bypass red CI if needed (for example with the v14 failing tests today).

image

I also disabled the Merge button (so we can use Squash or Rebase without worrying about using the wrong button) and "automatically delete head branches" after PR is merged (the branch can be restored, so it shouldn't be an issue).

image

Should make our life landing PRs easier. cc @nodejs/diagnostics

mhdawson commented 3 years ago

@mmarchini how does this affect doc only changes. I believe we allowed only the linter actions to be run for those versus requiring a full CI ?

mmarchini commented 3 years ago

I believe we allowed only the linter actions to be run for those versus requiring a full CI ?

Only on Node.js core, llnode barely has docs :)

mhdawson commented 3 years ago

Sorry never mind, missed that is was for llnode repo.