search

nodejs / llnode

An lldb plugin for Node.js and V8, which enables inspection of JavaScript states for insights into Node.js processes and their core dumps.
Other
1.15k stars 99 forks source link

Compilation warnings #374

Open amdoku opened 3 years ago

amdoku commented 3 years ago

When compiling with gcc-10.2.0 there are some warnings emitted.

The unit tests were failing when using gdb-9.2 and lldb-10.0.1 as the line would change from

error: error: use of undeclared identifier 'invalid_expr'

to

error: error: <user expression 3>:1:1: use of undeclared identifier 'invalid_expr'

This relaxes the test just enough to also work with older versions of gdb & lldb where this location information would not be included.

codecov-commenter commented 3 years ago

Codecov Report

Merging #374 into master will decrease coverage by 0.53%. The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #374      +/-   ##
==========================================
- Coverage   79.53%   79.00%   -0.54%     
==========================================
  Files          33       33              
  Lines        4744     4743       -1     
==========================================
- Hits         3773     3747      -26     
- Misses        971      996      +25
Impacted Files Coverage Δ
src/llscan.cc 59.41% <50.00%> (ø)
src/printer.cc 81.27% <66.66%> (+0.12%) :arrow_up:
src/llv8.cc 71.71% <100.00%> (-2.29%) :arrow_down:
test/plugin/scan-test.js 98.97% <100.00%> (ø)
src/llv8.h 81.81% <0.00%> (-2.28%) :arrow_down:
src/llv8-constants.h 97.05% <0.00%> (-1.48%) :arrow_down:
src/llv8-inl.h 90.42% <0.00%> (-0.82%) :arrow_down:
src/llv8-constants.cc 85.92% <0.00%> (-0.76%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4b868f7...9030cd7. Read the comment docs.