No9 commented 2 years ago

This PR uses the latest version of setup-node merged with the mirror branch from mmarchini's version. https://github.com/No9/setup-node/tree/mirror That branch has also been PR'd into the actions/setup-node upstream https://github.com/actions/setup-node/pull/360 If that isnt accepted I'm happy to open up a repo transfer request.

This PR also disables the ArrayBufferView and Arrow tests as they are currently failing.
The ArrayBufferView was identified here https://github.com/nodejs/llnode/issues/375 and appears to be an upstream issue with the mappings that are generated during the V8 build. It would be great to confirm that with @nodejs/post-mortem folks though.

The Arrow test is looking for a different function comparison in the test In 14.x it returns

[25]=0x3257a72b7c89:<function: 3378328 at /home/anton/build/llnode/test/fixtures/inspect-scenario.js:75:19>

Instead of 12.x

[25]=0x000036eccf7c0b79:<function: c.hashmap.(anonymous function) at /foo/bar.js:63:19>}

This is failing this regex

/\[25\]=(0x[0-9a-f]+):<(function: c.hashmap).*>/

If that is expected I can update the regex to be

/\[25\]=(0x[0-9a-f]+):<(function:.*>/

codecov-commenter commented 2 years ago

Codecov Report

Merging #398 (d3ae04e) into main (934ff7c) will decrease coverage by 2.84%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #398      +/-   ##
==========================================
- Coverage   79.43%   76.58%   -2.85%     
==========================================
  Files          34       34              
  Lines        5023     5023              
==========================================
- Hits         3990     3847     -143     
- Misses       1033     1176     +143

Impacted Files	Coverage Δ
src/llv8-inl.h	`82.16% <0.00%> (-8.54%)`	:arrow_down:
src/llv8-constants.cc	`80.09% <0.00%> (-6.22%)`	:arrow_down:
src/printer.cc	`74.30% <0.00%> (-5.70%)`	:arrow_down:
src/llv8.h	`72.41% <0.00%> (-5.18%)`	:arrow_down:
src/llv8-constants.h	`94.28% <0.00%> (-4.29%)`	:arrow_down:
src/llv8.cc	`69.41% <0.00%> (-2.27%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 934ff7c...d3ae04e. Read the comment docs.

mhdawson commented 2 years ago

@mmarchini are you going to get a chance to look at this as well?

nodejs / llnode

Update setup to latest, ignore ArrayBufferView and Arrow #398

Codecov Report