search

nodejs / llnode

An lldb plugin for Node.js and V8, which enables inspection of JavaScript states for insights into Node.js processes and their core dumps.
Other
1.15k stars 100 forks source link

src: fix warnings #415

Closed kvakil closed 2 years ago

kvakil commented 2 years ago

Fix various warnings which show up when compiling with gcc. For the most part this doesn't change any semantics -- the only user-facing change is a bug fix in Printer::Stringify caused by a missing return.

codecov-commenter commented 2 years ago

Codecov Report

Base: 73.54% // Head: 73.18% // Decreases project coverage by -0.36% :warning:

Coverage data is based on head (cadcb62) compared to base (d91aa40). Patch coverage: 77.77% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #415 +/- ## ========================================== - Coverage 73.54% 73.18% -0.37% ========================================== Files 34 34 Lines 5072 5071 -1 ========================================== - Hits 3730 3711 -19 - Misses 1342 1360 +18 ``` | [Impacted Files](https://codecov.io/gh/nodejs/llnode/pull/415?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [src/llv8.h](https://codecov.io/gh/nodejs/llnode/pull/415/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2xsdjguaA==) | `74.13% <ø> (ø)` | | | [src/printer.cc](https://codecov.io/gh/nodejs/llnode/pull/415/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3ByaW50ZXIuY2M=) | `75.29% <33.33%> (+0.10%)` | :arrow_up: | | [src/llscan.cc](https://codecov.io/gh/nodejs/llnode/pull/415/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2xsc2Nhbi5jYw==) | `60.56% <100.00%> (-1.86%)` | :arrow_down: | | [src/llv8.cc](https://codecov.io/gh/nodejs/llnode/pull/415/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2xsdjguY2M=) | `71.37% <100.00%> (-0.14%)` | :arrow_down: | | [src/llnode\_module.cc](https://codecov.io/gh/nodejs/llnode/pull/415/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2xsbm9kZV9tb2R1bGUuY2M=) | `87.79% <0.00%> (-0.59%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

No9 commented 2 years ago

LGTM - I'm rerunning the the flaky tests and then I'll land it. I'll also review the other PRs and then look to do a release.