nodejs / llnode

An lldb plugin for Node.js and V8, which enables inspection of JavaScript states for insights into Node.js processes and their core dumps.
Other
1.15k stars 100 forks source link

src: fix PropertyAttributesEnum_DONT_DELETE typo #418

Closed kvakil closed 2 years ago

kvakil commented 2 years ago

Frankly, this code is currently unused and it probably makes more sense to remove all of it entirely. But if we keep it, let's fix this typo I noticed.

codecov-commenter commented 2 years ago

Codecov Report

Base: 77.14% // Head: 73.16% // Decreases project coverage by -3.97% :warning:

Coverage data is based on head (0d4f9a7) compared to base (39b38a9). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #418 +/- ## ========================================== - Coverage 77.14% 73.16% -3.98% ========================================== Files 34 34 Lines 5023 5072 +49 ========================================== - Hits 3875 3711 -164 - Misses 1148 1361 +213 ``` | [Impacted Files](https://codecov.io/gh/nodejs/llnode/pull/418?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [src/llv8-constants.cc](https://codecov.io/gh/nodejs/llnode/pull/418/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2xsdjgtY29uc3RhbnRzLmNj) | `82.75% <100.00%> (+1.91%)` | :arrow_up: | | [src/node-inl.h](https://codecov.io/gh/nodejs/llnode/pull/418/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL25vZGUtaW5sLmg=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [src/node.h](https://codecov.io/gh/nodejs/llnode/pull/418/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL25vZGUuaA==) | `25.00% <0.00%> (-75.00%)` | :arrow_down: | | [src/node-constants.cc](https://codecov.io/gh/nodejs/llnode/pull/418/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL25vZGUtY29uc3RhbnRzLmNj) | `31.50% <0.00%> (-58.91%)` | :arrow_down: | | [src/node.cc](https://codecov.io/gh/nodejs/llnode/pull/418/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL25vZGUuY2M=) | `38.09% <0.00%> (-52.39%)` | :arrow_down: | | [test/plugin/workqueue-test.js](https://codecov.io/gh/nodejs/llnode/pull/418/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-dGVzdC9wbHVnaW4vd29ya3F1ZXVlLXRlc3QuanM=) | `51.85% <0.00%> (-48.15%)` | :arrow_down: | | [src/llnode.cc](https://codecov.io/gh/nodejs/llnode/pull/418/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2xsbm9kZS5jYw==) | `60.85% <0.00%> (-14.95%)` | :arrow_down: | | [src/llnode\_api.cc](https://codecov.io/gh/nodejs/llnode/pull/418/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2xsbm9kZV9hcGkuY2M=) | `85.41% <0.00%> (-10.42%)` | :arrow_down: | | [src/llv8-inl.h](https://codecov.io/gh/nodejs/llnode/pull/418/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2xsdjgtaW5sLmg=) | `74.96% <0.00%> (-7.97%)` | :arrow_down: | | [src/llnode.h](https://codecov.io/gh/nodejs/llnode/pull/418/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2xsbm9kZS5o) | `85.71% <0.00%> (-4.77%)` | :arrow_down: | | ... and [8 more](https://codecov.io/gh/nodejs/llnode/pull/418/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

No9 commented 2 years ago

Thanks @kvakil - Simple fix so I'm merging