nodejs / llnode

An lldb plugin for Node.js and V8, which enables inspection of JavaScript states for insights into Node.js processes and their core dumps.
Other
1.15k stars 99 forks source link

test: skip flaky JSArrayBuffer test #419

Closed kvakil closed 1 year ago

kvakil commented 1 year ago

This test failed a couple of times in #415, #417 and #418, so let's skip it for now.

codecov-commenter commented 1 year ago

Codecov Report

Base: 73.20% // Head: 72.18% // Decreases project coverage by -1.02% :warning:

Coverage data is based on head (205f26a) compared to base (8234105). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #419 +/- ## ========================================== - Coverage 73.20% 72.18% -1.03% ========================================== Files 34 34 Lines 5072 5072 ========================================== - Hits 3713 3661 -52 - Misses 1359 1411 +52 ``` | [Impacted Files](https://codecov.io/gh/nodejs/llnode/pull/419?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [src/llv8.h](https://codecov.io/gh/nodejs/llnode/pull/419/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2xsdjguaA==) | `68.96% <0.00%> (-5.18%)` | :arrow_down: | | [src/llv8-constants.cc](https://codecov.io/gh/nodejs/llnode/pull/419/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2xsdjgtY29uc3RhbnRzLmNj) | `79.80% <0.00%> (-2.96%)` | :arrow_down: | | [src/llv8-constants.h](https://codecov.io/gh/nodejs/llnode/pull/419/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2xsdjgtY29uc3RhbnRzLmg=) | `94.28% <0.00%> (-2.86%)` | :arrow_down: | | [src/llv8.cc](https://codecov.io/gh/nodejs/llnode/pull/419/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2xsdjguY2M=) | `69.10% <0.00%> (-2.40%)` | :arrow_down: | | [test/addon/jsapi-test.js](https://codecov.io/gh/nodejs/llnode/pull/419/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-dGVzdC9hZGRvbi9qc2FwaS10ZXN0Lmpz) | `95.71% <0.00%> (-1.43%)` | :arrow_down: | | [src/llnode\_api.cc](https://codecov.io/gh/nodejs/llnode/pull/419/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2xsbm9kZV9hcGkuY2M=) | `84.37% <0.00%> (-1.05%)` | :arrow_down: | | [test/common.js](https://codecov.io/gh/nodejs/llnode/pull/419/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-dGVzdC9jb21tb24uanM=) | `82.29% <0.00%> (-1.05%)` | :arrow_down: | | [src/printer.cc](https://codecov.io/gh/nodejs/llnode/pull/419/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3ByaW50ZXIuY2M=) | `74.30% <0.00%> (-0.88%)` | :arrow_down: | | [src/llv8-inl.h](https://codecov.io/gh/nodejs/llnode/pull/419/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2xsdjgtaW5sLmg=) | `74.09% <0.00%> (-0.88%)` | :arrow_down: | | [src/llnode\_module.cc](https://codecov.io/gh/nodejs/llnode/pull/419/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2xsbm9kZV9tb2R1bGUuY2M=) | `87.79% <0.00%> (-0.59%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

No9 commented 1 year ago

Merging and recorded here https://github.com/nodejs/llnode/issues/421