search

nodejs / llnode

An lldb plugin for Node.js and V8, which enables inspection of JavaScript states for insights into Node.js processes and their core dumps.
Other
1.15k stars 99 forks source link

tests: Fix flaky JSArrayBuffer test #421

Open No9 opened 1 year ago

No9 commented 1 year ago

The JSArrayBuffer has failed in node 18 in lldb versions 8, 11, 13, 14 but when re-ran they all pass. It's not clear what is causing it so we have it to optional in this PR https://github.com/nodejs/llnode/pull/419

Opening this to capture that it needs to be looked at and resolved if work is carried out in this area.

tony-go commented 1 year ago

Maybe could we close this one? @No9

No9 commented 1 year ago

Not sure why we want to close it @tony-go I opened it to capture that we have set JSArrayBuffer to optional which isn't ideal and should be looked at. That is still an issue I think unless there Is there something I've missed?

tony-go commented 1 year ago

I opened it to capture that we have set JSArrayBuffer to optional which isn't ideal and should be looked at.

My bad 🙌