nodejs / llnode

An lldb plugin for Node.js and V8, which enables inspection of JavaScript states for insights into Node.js processes and their core dumps.
Other
1.15k stars 99 forks source link

scripts: installation without sparse-checkout #425

Closed kvakil closed 1 year ago

kvakil commented 1 year ago

Old versions of Ubuntu (and likely other LTS distros) have git versions which do not support git-sparse-checkout. git-sparse-checkout is used as of #389.

Dynamically check if git sparse-checkout is supported, and if not then fallback to cloning the whole repo. Cloning the whole repo is slow, but at least it works.

I tested this patch on Ubuntu 18.04 without any lldb headers installed, and it worked successfully.

codecov-commenter commented 1 year ago

Codecov Report

Base: 73.65% // Head: 73.57% // Decreases project coverage by -0.08% :warning:

Coverage data is based on head (05ba77a) compared to base (eb969e1). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #425 +/- ## ========================================== - Coverage 73.65% 73.57% -0.09% ========================================== Files 34 34 Lines 4995 4995 ========================================== - Hits 3679 3675 -4 - Misses 1316 1320 +4 ``` | [Impacted Files](https://codecov.io/gh/nodejs/llnode/pull/425?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [src/llnode\_module.cc](https://codecov.io/gh/nodejs/llnode/pull/425/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2xsbm9kZV9tb2R1bGUuY2M=) | `87.79% <0.00%> (-0.59%)` | :arrow_down: | | [src/llv8.cc](https://codecov.io/gh/nodejs/llnode/pull/425/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2xsdjguY2M=) | `71.23% <0.00%> (-0.40%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.