Closed kvakil closed 1 year ago
Base: 73.65% // Head: 73.59% // Decreases project coverage by -0.05%
:warning:
Coverage data is based on head (
4a950e7
) compared to base (eb969e1
). Patch coverage: 40.00% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Thanks ^^
Definitely better than segfault. 😃
But we don't really know why that is happening. I'm correct?
LGTM to so merging
This "fixes" the segfault reported in #422, in the sense that you no longer get a segfault. However the printing does not actually work, i.e. you currently get an error like this:
I'm deeming this better than segfaulting. We should really never be segfaulting as the coredump might be incomplete/partially corrupted. (Also, we already know function printing on v16 doesn't work right now.)