Support llvm dev releases

nodejs / llnode

An lldb plugin for Node.js and V8, which enables inspection of JavaScript states for insights into Node.js processes and their core dumps.

Other

1.15k stars 100 forks source link

Support llvm dev releases #433

Open trxcllnt opened 7 months ago

trxcllnt commented 7 months ago

This is a followup to https://github.com/nodejs/llnode/pull/389:

Updates the range of LLVM versions we check (from 20, which is next dev version, to 99)
Support downloading headers if the detected lldb version is the current dev release
- i.e. doesn't have a release/XY.x branch, but does have a llvmorg-XY-init tag
Update the PR action to test ubuntu-22.04 + LLVM versions up to current dev (v19)

If we wanted to be fancy, we could populate the supported versions and CI matrix by parsing git ls-remote --tags https://github.com/llvm/llvm-project.git 'refs/tags/llvmorg-*-init'.

Let me know if that's something you'd like me to add!

codecov-commenter commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 73.75%. Comparing base (de1f01d) to head (1d965d1).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #433 +/- ## ========================================== - Coverage 74.25% 73.75% -0.51% ========================================== Files 34 34 Lines 4999 5181 +182 ========================================== + Hits 3712 3821 +109 - Misses 1287 1360 +73 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

trxcllnt commented 2 months ago

It appears the lldb headers in llvm-19 now include headers generated by the build, so downloading them from github is insufficient to build llnode. I'm not sure what to do about that.

@No9 do you have any thoughts on this PR?