search

nodejs / nan

Native Abstractions for Node.js
MIT License
3.29k stars 505 forks source link

Scriptorigin #918

Closed kkoopa closed 3 years ago

kkoopa commented 3 years ago

To properly address #917 requires reimplementing v8::ScriptOrigin due to v8/v8@546939fe77cdeee1f870b7393a82d88525a67963 (unintentionally?) breaking the old ScriptOrigin constructor by making resource_column_offset required. Since the same commit marked ScriptOrigin::ResourceLineOffset and ScriptOrigin::ResourceColumnOffset as soon to be deprecated, they should be reimplemented. Finally, @bnoordhuis decided to add a requirement for passing a v8::Isolate* in v8/v8@ee3f5ba10b47e21775634f9b5fcd47e06453c793, with the other constructors facing future deprecation.

kkoopa commented 3 years ago

Seems no tests want to run. AppVeyor is acting weird for unknown reasons, while Travis claims that builds have been disabled due to lack of credits.

kkoopa commented 3 years ago

AppVeyor acting weird was due to VS2015 not being a proper compiler. Worked around it while sticking to C++03 by implementing forwarding constructors for all three supported constructors for all versions.