search

nodejs / nan

Native Abstractions for Node.js
MIT License
3.27k stars 501 forks source link

Add Node.js 20 #949

Closed westy92 closed 1 year ago

westy92 commented 1 year ago

I attempted to copy https://github.com/nodejs/nan/pull/945.

westy92 commented 1 year ago

AppVeyor succeeded. ✅ https://ci.appveyor.com/project/RodVagg/nan/builds/46876091

westy92 commented 1 year ago

What is the process for getting a release with this included?

kkoopa commented 1 year ago

Well, since it does not actually do anything, there will not be a release in the foreseeable future. The version detection is only used for handling specific logic, which does not apply to Node 20 as far as I am aware. The current version of NAN exhibits identical behavior. I have not personally tried Node 20, but unless there is something specifically broken, of which I am not aware, ecerything ahould work fine with the current version. Thank you for the contribution though, it would still have had to be added at some point.

On April 29, 2023 9:40:14 PM GMT+03:00, Seth Westphal @.***> wrote:

What is the process for getting a release with this included?