Cast `v8::Object::GetInternalField()` return value to `v8::Value`

nodejs / nan

Native Abstractions for Node.js

MIT License

3.27k stars 501 forks source link

Cast `v8::Object::GetInternalField()` return value to `v8::Value` #956

Closed codebytere closed 12 months ago

codebytere commented 12 months ago

Refs https://github.com/nodejs/node/pull/48943 Refs https://chromium-review.googlesource.com/c/v8/v8/+/4834471

Electron is hitting build failures on this as a result of the above CL - This PR fixes these issues by casting v8::Object::GetInternalField() return values to v8::Value.

kkoopa commented 12 months ago

Thank you.