search

nodejs / nan

Native Abstractions for Node.js
MIT License
3.27k stars 501 forks source link

Use GitHub Actions and delete Travis / AppVeyor configuration #958

Open tniessen opened 10 months ago

tniessen commented 10 months ago

Some internal discussion suggests that we should migrate all organization repositories to GitHub Actions. As far as I am aware, this is the only remaining repository in the Node.js organization that has a Travis configuration.

This issue is not a duplicate of but likely supercedes https://github.com/nodejs/nan/issues/508.

kkoopa commented 10 months ago

Yes, please. Travis has not worked for years and AppVeyor is slow. I presume Windows testing is available as well. I have never used Github Actions.

On October 21, 2023 5:29:59 PM GMT+03:00, "Tobias Nießen" @.***> wrote:

Some internal discussion suggests that we should migrate all organization repositories to GitHub Actions. As far as I am aware, this is the only remaining repository in the Node.js organization that has a Travis configuration.

This issue is not a duplicate of but likely supercedes https://github.com/nodejs/nan/issues/508.

tniessen commented 10 months ago

I presume Windows testing is available as well. I have never used Github Actions.

Yes. Currently, the list of supported platforms through GitHub-hosted runners includes ubuntu-22.04, ubuntu-20.04, windows-2022, windows-2019, macos-13, macos-12, and macos-11. We typically run tests using the aliases ubuntu-latest, windows-latest, and macos-latest so that we don't need to update any configuration as GitHub upgrades their platforms.