search

nodejs / nan

Native Abstractions for Node.js
MIT License
3.27k stars 501 forks source link

can this node-gyp warning be dealt with? #962

Open eric-g-97477 opened 9 months ago

eric-g-97477 commented 9 months ago

I am using node 18.18.2 and yarn 3.2.4.

If I do:

  1. mkdir test
  2. cd test
  3. yarn init
  4. yarn add nan

I get the warning:

➤ YN0032: │ nan@npm:2.18.0: Implicit dependencies on node-gyp are discouraged

I aim for zero-warnings because unimportant warnings make it hard to notice important warnings.

Can this warning be dealt with?

kkoopa commented 9 months ago

I have never used yarn, but to me it seems the warning comes from yarn and not from node-gyp. According to the yarn documentation, you can set a logFilter in .yarnrc to suppress it.

On November 13, 2023 6:21:08 PM GMT+02:00, Eric @.***> wrote:

I am using node 18.18.2 and yarn 3.2.4.

If I do:

  1. mkdir test
  2. cd test
  3. yarn init
  4. yarn add nan

I get the warning:

➤ YN0032: │ ***@***.***:2.18.0: Implicit dependencies on node-gyp are discouraged

I aim for zero-warnings because unimportant warnings make it hard to notice important warnings.

Can this warning be dealt with?

eric-g-97477 commented 9 months ago

Ok. Still seems like it is a good recommendation. You may want to reconsider the implicit dependency. Feel free to close this issue if you know otherwise or keep it open as a reminder to investigate further.

kkoopa commented 9 months ago

Cannot do that. They are intentionally pinned to specific versions since nothing else works across the board.

On November 13, 2023 9:44:08 PM GMT+02:00, Eric @.***> wrote:

Ok. Still seems like it is a good recommendation. You may want to reconsider the implicit dependency. Feel free to close this issue if you know otherwise or keep it open as a reminder to investigate further.