Fix builds for Electron 29

indutny-signal commented 6 months ago

ObjectTemplate::SetAccessor signature has changed in the V8 >= 12, and no longer accepts v8::AccessControl parameter. The v8::AccessControl enum is in fact a single value now so no public users of nan would be broken if we just stop passing it down to V8.

indutny-signal commented 6 months ago

cc @kkoopa

kkoopa commented 6 months ago

Thank you. I'll get this out next week when I am home.

indutny-signal commented 6 months ago

Yay! Thank you so much!

chrbongardt commented 6 months ago

Hey @kkoopa could we please get a release with this fix <3

kkoopa commented 4 months ago

I can push out a minor update with a fix quickly, but let us wait and see what the V8 response is.

On April 16, 2024 3:20:36 PM GMT+03:00, Robo @.***> wrote:

@deepak1556 commented on this pull request.

@@ -2550,7 +2550,9 @@ NANDEPRECATED inline void SetAccessor( , getter , setter_ , obj +#if !defined(V8_MAJOR_VERSION) || V8_MAJOR_VERSION < 12

Asked about it in the relevant V8 CL https://chromium-review.googlesource.com/c/v8/v8/+/5006387/comment/65b3eecb_f7eb5d8f/

-- Reply to this email directly or view it on GitHub: https://github.com/nodejs/nan/pull/966#discussion_r1567260949 You are receiving this because you were mentioned.

Message ID: @.***>

nodejs / nan

Fix builds for Electron 29 #966