search

nodejs / next-10

Repository for discussion on strategic directions for next 10 years of Node.js
Other
477 stars 24 forks source link

Chore(ignore): add git #205

Closed AugustinMauroy closed 1 year ago

AugustinMauroy commented 1 year ago

https://github.com/nodejs/next-10/blob/e1f2042b0aca14add92cd6907e80e0237e8d98f1/surveys/.DS_Store

mhdawson commented 1 year ago

@AugustinMauroy I need more context to be able to understand the what/why for this PR.

AugustinMauroy commented 1 year ago

I don't know when but we had pushed an .DS_store it's an unix file(binary). So we should put in ignore.

wesleytodd commented 1 year ago

Here is the file: https://github.com/nodejs/next-10/blob/main/surveys/.DS_Store

That said, I don't understand adding *.pem. Did you see someone pushing a .pem file in here?

AugustinMauroy commented 1 year ago

it's an other unix file

wesleytodd commented 1 year ago

It is a cert file as part of making an ssl cert, and I have no idea why anyone would commit those. I dont like having this in the .gitignore unless something in this repo clearly needed it, which I don't think it does.

mhdawson commented 1 year ago

I'm going to close this out as we don't believe its needed.