nodejs / node-chakracore

Node.js on ChakraCore :sparkles::turtle::rocket::sparkles:
Other
1.92k stars 340 forks source link

cctest test_platform.cc fails on node-chakracore #529

Closed boingoing closed 6 years ago

boingoing commented 6 years ago

The new cctest.exe test in test_platform.cc fails on node-chakracore due there being no context when we try to create a string:

[----------] 1 test from PlatformTest
[ RUN      ] PlatformTest.SkipNewTasksInFlushForegroundTasks
FATAL ERROR: v8::ToLocalChecked: Empty MaybeLocal.
Important: While trying to check Javascript exception, JsHasException has also failed.

Adding a v8::Context::Scope to SkipNewTasksInFlushForegroundTasks which either reuses env.context() or creates a new context from the isolate causes the test to fail with a SEH exception:

[----------] 1 test from PlatformTest                                                                                                         
[ RUN      ] PlatformTest.SkipNewTasksInFlushForegroundTasks                                                                                  
unknown file: error: SEH exception with code 0xc0000005 thrown in the test body.                                                              
[  FAILED  ] PlatformTest.SkipNewTasksInFlushForegroundTasks (8 ms)                                                                           
cmd - cctest.exe[26076]: e:\node\node-chakracore\test\cctest\node_test_fixture.h:84: Assertion `(0) == (uv_loop_close(&current_loop))' failed.
 1: node::Abort                                                                                                                               
 2: node::Assert                                                                                                                              
 3: NodeTestFixture::TearDownTestCase                                                                                                         
 4: testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test,void>                                                             
 5: testing::TestCase::Run                                                                                                                    
 6: testing::internal::UnitTestImpl::RunAllTests                                                                                              
 7: testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,bool>                                           
 8: main                                                                                                                                      
 9: __scrt_common_main_seh                                                                                                                    
10: BaseThreadInitThunk                                                                                                                       
11: RtlUserThreadStart                                                                                                                        

I disabled this test for now until we can solve the context issue.

kfarnung commented 6 years ago

Disabled in 16a9ce775518595451792f7e557a7603a54904da