search

nodejs / node-chakracore

Node.js on ChakraCore :sparkles::turtle::rocket::sparkles:
Other
1.92k stars 342 forks source link

buffer,test: remove species workaround #575

Closed kfarnung closed 6 years ago

kfarnung commented 6 years ago
Checklist
kfarnung commented 6 years ago

CI: https://ci.nodejs.org/job/chakracore-test-pull-request/291/

kfarnung commented 6 years ago

Linter re-run: https://ci.nodejs.org/job/node-test-linter/20731/

kfarnung commented 6 years ago

Re-enabled a couple of other tests that had their ChakraCore issues fixed and kicked off a new CI: https://ci.nodejs.org/job/chakracore-test-pull-request/292/

MSLaguana commented 6 years ago

LGTM

kfarnung commented 6 years ago

Restarted the macOS CI leg: https://ci.nodejs.org/job/chakracore-test-osx/392/

kfarnung commented 6 years ago

Fixed some other differences in test-repl-top-level-await, hopefully the last CI: https://ci.nodejs.org/job/chakracore-test-pull-request/293/