search

nodejs / node-chakracore

Node.js on ChakraCore :sparkles::turtle::rocket::sparkles:
Other
1.92k stars 342 forks source link

src,test: stub out bigint #577

Closed kfarnung closed 6 years ago

kfarnung commented 6 years ago

Stubbed out the functions to return napi_ok since there's no napi_not_implemented which would be better.

Fixed a couple of lint issues in tests

Checklist
kfarnung commented 6 years ago

@mhdawson @gabrielschulhof Would it make sense to add a status code for Not implemented?

kfarnung commented 6 years ago

CI: https://ci.nodejs.org/job/chakracore-test-pull-request/294/

MSLaguana commented 6 years ago

Instead of napi_ok, perhaps go with napi_bigint_expected since we know we won't ever have an actual bigint, at least until we support them.

kfarnung commented 6 years ago

I'm going to land this with napi_ok and come back to it.